PR: Update README with information on Pyright/Pylance integration and add CLI subcommand to help generate the related config #450
Conversation
There was a problem hiding this comment.
Great work here @wkrasnicki ! Thank you so much for taking the time to not only update the README but also extend the CLI support to get the configs! I think the only missing element here is to add a test at https://github.com/spyder-ide/qtpy/blob/master/qtpy/tests/test_cli.py for the new CLI command but other than that this LGTM 👍
That makes sense, we planned to use I think we added the What do you think @ccordoba12 @CAM-Gerlach ? |
dalthviz
changed the title
|
Ah, the power of tests. It actually caught a bug with boolean values not being lowercase in TOML 😅 |
|
Btw I have black formatter configured in my IDE to format on save and it looks like it changed the formatting a bit. Sorry for that, would you like me to revert these changes? |
I did a quick check and seem small enough, so no problem with just leaving them 👍 |
I think that work should be finished since more and more people are contributing to this project. Formatting the code with Black and then adding pre-commit should be enough. |
|
And thank you for all the support and prompt responses @dalthviz |
dalthviz
changed the title
My proposition of updated README and CLI that explains how to update the pyright configuration to eliminate type checking errors, especially in VSCode.
Solution based on this comment and follows the discussion from my issue.
NOTE:
I couldn't get the pre-commit hooks to run. It seems that some of them are outdated and raise this error that has been fixed in newer versions. After updating, however, the yamllint check was throwing errors instead, so I left it as is.
Fixes #447.